Closed JohanSchott closed 3 months ago
I'll merge this PR in a couple of days unless someone objects or provide feedback.
This looks good to me. However, I notice that you only use the bytes
representation for the product states. Maybe it would be a good idea to test with int
and the other representations as well?
Thanks for your review @johanjoensson !
True, only test with bytes
.
The current implementation of applyOp
can only handle product states in the bytes representation.
Does other representations, e.g. int
, work in your fork version?
Sorry, I was confused. My version of applyOp
also only accepts bytes
as well.
Alright!
If it looks good to you, would you like to click the "approve" button?
So I can skip the red and dangerously looking "Merge without waiting for requirements to be met" button:
Add unit-tests to the function
applyOp
inimpurityModel/ed/finite.py
.applyOp
is a cornerstone of this repo. It applied an operator on a multi-configurational state and returns the resulting multi-configurational state.The input operator can be anything (following the syntax: dict(process: process_amplitude))
The input multi-configurational state can be anything (following the syntax: dict(product_state: product_state_probability_amplitude))