search

Johann-S / bs-customizer

Create a custom Bootstrap 4.x build
https://johann-s.github.io/bs-customizer/
MIT License
17 stars 2 forks source link

Accessibility fixes. #18

Closed XhmikosR closed 6 years ago

XhmikosR commented 6 years ago

Only @patrickhlauke can help us with this more :)

Basically a review of this patch and how we should handle the loader.

patrickhlauke commented 6 years ago

LGTM

XhmikosR commented 6 years ago

@patrickhlauke: thanks! How about the loader? https://github.com/Johann-S/bs-customizer/blob/master/src/dialog-loader.js#L22

patrickhlauke commented 6 years ago

i'd need to see it in action, but likely you'll want to have a look at something like the button in https://codepen.io/patrickhlauke/pen/dddMqO

XhmikosR commented 6 years ago

You can see it in action here https://johann-s.github.io/bs-customizer/, just choose a plugin and hit download :)