search

Johann-S / bs-customizer

Create a custom Bootstrap 4.x build
https://johann-s.github.io/bs-customizer/
MIT License
17 stars 2 forks source link

Use reboot instead of root #25

Closed MartijnCuppens closed 5 years ago

Johann-S commented 5 years ago

The root allow folks to customize the color of our components 😟 so without that they can't, so I'm not in favor of removing root, but you can add reboot for our components 👍

MartijnCuppens commented 5 years ago

root only adds some custom properties (css variables). It doesn't allow people to change the color of components (or am I missing something 😛).

Johann-S commented 5 years ago

Oh ok, so in which situation should we include _root.scss ?

Johann-S commented 5 years ago

Hmm I change the target branch but it did something wrong 🤔 it added commits which are already merged in master

Johann-S commented 5 years ago

Oh ok, so in which situation should we include _root.scss ?

If you have some information about that @XhmikosR ?

XhmikosR commented 5 years ago

Root is only for CSS variables. It's a separate component. Reboot isn't optional and should always be included when any CSS is included.

Johann-S commented 5 years ago

Hmm ok I understand, but I don't know when we should add _root.scss and when we shouldn't add it 🤔

XhmikosR commented 5 years ago

It's a separate component. So only if its selected

On Thu, Sep 27, 2018, 22:10 Johann-S notifications@github.com wrote:

Hmm ok I understand, but I don't know when we should add _root.scss and when we shouldn't add it 🤔

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Johann-S/bs-customizer/pull/25#issuecomment-425209433, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVVtdx5Tcj49Cg-NZ0qiBh5_SuVjqmyks5ufSK0gaJpZM4W9Okx .

Johann-S commented 5 years ago

@XhmikosR https://github.com/Johann-S/bs-customizer/commit/27ab82335f27960a70dc89636e4eb0f382b912ee 😉

Johann-S commented 5 years ago

Sorry @MartijnCuppens I did what you did... So I'll close this PR.

The things, is, Root isn't present in Bootstrap documentation so nobody knows, there is a Root component 😟

XhmikosR commented 5 years ago

Yeah because it was an experiment and might be removed at any time.