search

Johann-S / bs-customizer

Create a custom Bootstrap 4.x build
https://johann-s.github.io/bs-customizer/
MIT License
17 stars 2 forks source link

split our entry points #54

Closed Johann-S closed 6 years ago

Johann-S commented 6 years ago

Fixes: https://github.com/Johann-S/bs-customizer/issues/30

XhmikosR commented 6 years ago

What's that styles-index file for? Also why is ~ used in the filenames?

Johann-S commented 6 years ago

I don't know those files are generated by Webpack, about ~ we can change that in the config if you prefer

XhmikosR commented 6 years ago

This branch is like 80KB more, so something doesn't feel right to me. Splitting shouldn't increase the JS size so much.

Johann-S commented 6 years ago

Standard do not support well dynamic imports... I found a solution here: https://github.com/standard/standard/issues/751

But I'm waiting for what you think about that change @XhmikosR : https://gtmetrix.com/compare/pAMMwiLJ/l0Ganj4K

XhmikosR commented 6 years ago

Definitely good since the bundle size goes down :)