Murder Mystery Review

[franfranfranfran]

Rubric Score

Criteria 1: Valid Python Code

• Score Level: 4
• Comment(s): Code runs without any errors!

Criteria 2: Implementation of Project Requirements

• Score Level: 4
• Comment(s): Great job hitting all the major points of this project! All the necessary functions and classes are in place and ready to go.

Criteria 3: Software Architecture

• Score Level: 2
• Comment(s): The find_text_similarity function should take two TextSample arguments instead of two chunks of raw text. This is important to note, both because a good amount of the work you do in this function is already done when creating the three text samples (finding sentence length, etc.). Also, you are calculating these values with completely raw text (text that still has the varied punctuation), so the results are potentially not accurate. Also, in the TextSample class, try to take advantage of the fact that you stored the prepared text. Do you need to re-prepare it multiple times in order to use it in word_count_frequency and n_gram_frequency?

Criteria 4: Uses Python Language Features

• Score Level: 3
• Comment(s): Great use of various built-in python language features like the abs() method, replace(), split(), and many others. Just one thing to note about the keys method: -No need to use the keys() method when you need the keys like in many of your for loops - for word in table1: - will work exactly how you expect it to.

Criteria 5: Produces Accurate Output

• Score Level: 2
• Comment(s): Something is off with how you copied over Gregg T Fishy's intro text. The sentence length average is quite a bit different from what it should be, which could potentially completely throw off the result for overall similarity (which might lead to you accusing the wrong person of murder!). Try copy and pasting this text again and maybe even computing the sentence length average manually for this and another intro to make sure your function is working correctly.

Overall Score: 15/20

Great start on this project. With a few key tweaks, everything will be looking great. Great thought to include tests for the many functions throughout the project. This kind of testing can go a long way to make sure your results are accurate. Even with all the tests in the world, things can still sometimes slip through the cracks - double check some of the sections I noted above to make sure the end results are as accurate as possible. Have fun and keep up the good work!

[Johann2012]

Thank you for the review. Unfortunately I am traveling for the next week and I am not sure if i will get to all the changes you specified. I copied and pasted Gregg's text again and it did give me a different answer. I hope this is enough to pass this class.

[franfranfranfran]

That's ok, no need to make any changes to pass. They are for your own learning. Have a good trip!

On Tue, Feb 19, 2019 at 10:57 AM Jeasy notifications@github.com wrote:

Thank you for the review. Unfortunately I am traveling for the next week and I am not sure if i will get to all the changes you specified. I copied and pasted Gregg's text again and it did give me a different answer. I hope this is enough to pass this class.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Johann2012/pwp-capstones/issues/1#issuecomment-465190797, or mute the thread https://github.com/notifications/unsubscribe-auth/AQdb-x0rvbzE4Y_IZ9N0S5asj0NMfdOEks5vPB78gaJpZM4bDJ_O .