Remove outdated Python2 code

JohannesBuchner / imagehash

A Python Perceptual Image Hashing Module

BSD 2-Clause "Simplified" License

3.19k stars 329 forks source link

Remove outdated Python2 code #197

Open Rotzbua opened 1 year ago

Rotzbua commented 1 year ago

Change

Remove outdated Python2 code
Remove six package

coveralls commented 1 year ago

coverage: 87.805% (-0.04%) from 87.847% when pulling 1849bc46ca9e8c5fc0634aabe2db4fdd7fc75c97 on Rotzbua:remove_python2_code into 5e9ef5d3cdd822ae1a325b1eaf0bbe4eda4090cd on JohannesBuchner:master.

JohannesBuchner commented 1 year ago

imagehash had Python 2 support much longer than other packages, and it helped a number of users stuck on ancient systems that do not receive updates. I had PRs from several people over the years trying to remove it and calling it outdated.

Unfortunately it has basically become impossible to run CI against such old versions now. So I think we may have to go with the times and say goodbye to Python 2 support at this point and recommend the affected users to use old versions.

JohannesBuchner commented 2 months ago

Hi @Rotzbua, sorry for picking this up so late. I'd be happy to merge this, but I see that there is a conflict. Can you please fix it?