search

JohannesBuchner / regulargrid

Regular Grid Multivariate linear interpolation
BSD 2-Clause "Simplified" License
21 stars 1 forks source link

permission to include code into Scipy #2

Closed andreas-h closed 10 years ago

andreas-h commented 10 years ago

Hi,

I'd like some of the code in this repository to be included in the scipy.interpolate module. I'm currently preparing a pull request for scipy which contains code largely based on what you have in regulargrid.py.

I hereby ask permission for this code to be included into Scipy (given that the Scipy team actually want it), which is BSD-licensed.

Best regards, Andreas.

JohannesBuchner commented 10 years ago

That's fine, but please be aware that most of the code can be replaced by the ~ three lines in https://github.com/JohannesBuchner/regulargrid/blob/master/regulargrid/cartesiangrid.py because scipy.ndimage.map_coordinates solves that problem in a very general way. It is very performant too. Perhaps a thin wrapper for this function like CartesianGrid is enough.

andreas-h commented 10 years ago

Isn't map_coordinates and CartesianGrid limited to equally spaced grids? I'm interested in rectangular grids which have variable/uneven spacing.

JohannesBuchner commented 10 years ago

Yes. Oh yeah, I implemented uneven spacing, didn't I. It's been such a long time ... Anyways, have fun with the code.

andreas-h commented 10 years ago

Great, thanks a lot =) I'll keep you updated.

andreas-h commented 10 years ago

Just wanted to let you know that the new functionality, based on your regulargrid implementation, is now merged into scipy master: https://github.com/scipy/scipy/commit/a90dc2804da21ba4c48c2615facd0ac5848ebe59. Thanks again for giving permission to do this work!

JohannesBuchner commented 10 years ago

Wicked. Thank you.