Added -q --sequential option for running the program single-threaded.

JohannesEbke / aws_list_all

List all your AWS resources, all regions, all services.

MIT License

414 stars 97 forks source link

Added -q --sequential option for running the program single-threaded. #14

Closed bkcnimbis closed 5 years ago

bkcnimbis commented 5 years ago

This is a nice tool but wasn't working for me, so I made it work for me. The option to run single-threaded is very useful where memory usage is a concern and running time isn't. Additionally, this addresses issue #7 by cutting out the call to multiprocessing methods when the option is specified.

The managedblockchain commit was necessary for the tool to run on my machine, so it is included here as well.

felixhuttmann commented 5 years ago

Your workaround for the managedblockchain error still leaves the tests failing: https://travis-ci.org/JohannesEbke/aws_list_all/jobs/532946893

I think managedblockchain has to be added to the SERVICE_BLACKLIST and I have updated my pull request accordingly. https://github.com/JohannesEbke/aws_list_all/pull/12

bkcnimbis commented 5 years ago

Passes tests now. To be clear, f0c7706 (and 6e04ba7 depending on what you're doing with yapf) is the sole commit containing a useful contribution, and I'll happily resubmit a PR rebased from any passing commit @JohannesEbke likes.

I'd like to see this option pulled in

JohannesEbke commented 5 years ago

Hi @bkcnimbis ; thanks for the Idea and all the work! I've picked up the idea, but implemented it as a "--parallel N" flag, where N is the number of parallel requests in flight. I've left the pool in, since #7 has been fixed otherwise.