search

JohannesHoppe / angular-date-value-accessor

Home of the Angular DateValueAccessor for <input type="date">
http://johanneshoppe.github.io/angular-date-value-accessor/
MIT License
78 stars 19 forks source link

Compatibility with Angular 9 #16

Closed juerggnos closed 4 years ago

juerggnos commented 4 years ago

Hello,

I'm trying to upgrade a project from angular 8 to 9 which uses this angular-date-value-accessor. Unfortunately compilation fails because Renderer (deprecated and replaced (with Renderer2) since Angular 4 and removed since Angular 9) is imported from @angular/core module.

Would it be possible to provide a new version of this angular-date-value-accessor which is compatible with Angular 9?

JohannesHoppe commented 4 years ago

Thanks for the info! Do you mind creating a pull request?! 🙂👍

juerggnos commented 4 years ago

Pull request created, was not able to link it with the issue. Here it is: https://github.com/JohannesHoppe/angular-date-value-accessor/pull/17

JohannesHoppe commented 4 years ago

Awesome! I will merge on Monday! 👍

schonbachler commented 4 years ago

Which Monday?

juerggnos commented 4 years ago

Cool, the pull request was merged. Thank you! When will a new version be published?

JohannesHoppe commented 4 years ago

I have looked at my ancient code and I am amazed that it seems to work at all. The whole thing was built at a time when ng-packagr did not even exist. Whew... I think there's no way around it, there's still additional work to be done...

JohannesHoppe commented 4 years ago

...in example, the package.json is taking most of the generated files in account, but not the module.ngfactory.js and friends. I really don't know if this would break thinks or not. Additionally, the package breaks literally every aspect of the Angular Package Format.

Right now I'm not confident enough to publish this to npm.

JohannesHoppe commented 4 years ago

But I'm on it now! 😄

JohannesHoppe commented 4 years ago

@schonbachler I just pushed a preview version (1.0.0-rc.1) to NPM. It's made on top of Angular 9, without Ivy. Could you please check if it works for you?!

The demo works, but I wasn't able to successfully execute the tests...