search

JohannesKaufmann / html-to-markdown

⚙️ Convert HTML to Markdown. Even works with entire websites and can be extended through rules.
https://html-to-markdown.com
MIT License
892 stars 85 forks source link

Add support for youtube-nocookie.com domain in YoutubeEmbed plugin #99

Closed devAbreu closed 5 months ago

devAbreu commented 5 months ago

Description

This pull request adds support for handling YouTube iframes using the youtube-nocookie.com domain in the YoutubeEmbed plugin.

Changes Made

Justification

youtube-nocookie.com is a variant of YouTube that is used to enhance user privacy by not storing cookies. These changes will allow the plugin to correctly handle these iframes.

Thank you for considering this improvement.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.11%. Comparing base (2ec2259) to head (69ed8b8).

:exclamation: Current head 69ed8b8 differs from pull request most recent head 0faed87

Please upload reports for the commit 0faed87 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #99 +/- ## ======================================= Coverage 97.11% 97.11% ======================================= Files 4 4 Lines 971 971 ======================================= Hits 943 943 Misses 19 19 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JohannesKaufmann commented 5 months ago

@devAbreu thanks a lot for submitting the PR! This sounds like a good improvement 👍

Just one thing: Please remove the logging for now.

(Logging should be customizable, maybe only when a debug mode is activated. Or when a logger is passed in. Since we don't have that yet, I would leave this out for now...)

devAbreu commented 5 months ago

@JohannesKaufmann Great. Thank you for the suggestion. 👍🏿