Concurrency issues if two controls are connected to OSC at the same time

JohannesLorenz / lmms-zyn-fusion-test

Inofficial installer for LMMS with zyn fusion plugin

4 stars 0 forks source link

Concurrency issues if two controls are connected to OSC at the same time #3

Closed JohannesLorenz closed 4 years ago

JohannesLorenz commented 5 years ago

The ringbuffer library explicitly says that there shall only be one writer. This is currently violated in SpaControlBase::writeOscInternal . This can happen if one control is connected to a controller, the other to an automation pattern.

Solution: Use a spin lock based on an atomic.

JohannesLorenz commented 4 years ago

Fixed in SpaProc in the lmms repo in 98f9a96.