search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
592 stars 104 forks source link

Duplicated quotes #32

Closed srosebattles closed 1 year ago

srosebattles commented 1 year ago

A number of quotes are the same, just cut slightly different with more or less text. Is this intended/desired? e.g. 00:00|twelve|Bernardo: 'Tis now struck twelve; get thee to bed, Francisco.|Hamlet |Shakespeare|unknown 00:00|twelve|Francisco. You come most carefully upon your hour. Bernardo. 'Tis now struck twelve. Get thee to bed, Francisco.|Hamlet |William Shakespeare|unknown

JohannesNE commented 1 year ago

This is not intended. In this case I prefer nr two, but with the punctuation from nr 1 :shrug: I do not have a strong opinion on this though.

Thank you very much for your PR (https://github.com/JohannesNE/literature-clock/pull/33) I will look though it and generate the .json files ASAP.

srosebattles commented 1 year ago

I think a lot of these duplicates were introduced with https://github.com/JohannesNE/literature-clock/pull/29. I'd be happy to go through and do some editing if you haven't already started doing that. I'll put it up as a separate PR, though.

JohannesNE commented 1 year ago

Ahh, that seems likely.

That would be very helpful. I do not have much extra time ATM.

On Thu, Sep 8, 2022, 17:40 srosebattles @.***> wrote:

I think a lot of these duplicates were introduced with #29 https://github.com/JohannesNE/literature-clock/pull/29. I'd be happy to go through and do some editing if you haven't already started doing that. I'll put it up as a separate PR, though.

— Reply to this email directly, view it on GitHub https://github.com/JohannesNE/literature-clock/issues/32#issuecomment-1240891618, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACUJOOASULF4BHUIJ6CM2ZTV5ICHZANCNFSM6AAAAAAQFLFDQE . You are receiving this because you commented.Message ID: @.***>

JohannesNE commented 1 year ago

fixed in #34