search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
598 stars 105 forks source link

Generated json files are malformed #36

Closed ikornaselur closed 2 years ago

ikornaselur commented 2 years ago

Unfortunately the run of the R script from #34 has introduced malformed json output, specifically sections such as:

https://github.com/JohannesNE/literature-clock/blob/6a0a6a84fc499f2e254fec5f2259db7b593c842d/docs/times/01_30.json#L33 https://github.com/JohannesNE/literature-clock/blob/6a0a6a84fc499f2e254fec5f2259db7b593c842d/docs/times/02_04.json#L6 https://github.com/JohannesNE/literature-clock/blob/6a0a6a84fc499f2e254fec5f2259db7b593c842d/docs/times/03_00.json#L438 https://github.com/JohannesNE/literature-clock/blob/6a0a6a84fc499f2e254fec5f2259db7b593c842d/docs/times/11_30.json#L69 https://github.com/JohannesNE/literature-clock/blob/6a0a6a84fc499f2e254fec5f2259db7b593c842d/docs/times/13_20.json#L15 https://github.com/JohannesNE/literature-clock/blob/6a0a6a84fc499f2e254fec5f2259db7b593c842d/docs/times/18_04.json#L6

it seems that the value has multiple entries within it. They should be simple to find by grepping for | within the json files. Looks like it could be an incorrect delimiter handling somehow?

fbtot commented 2 years ago

There are some errors in the formatting of the CSV, little things like opening a dialogue with " and closing it with ”. I'm already working on this.

JohannesNE commented 2 years ago

Thank you. I overlooked this. Opened a new issue related to this, with the intend of making the csv simpler to edit.

https://github.com/JohannesNE/literature-clock/issues/38