search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
592 stars 104 forks source link

Fix br tag not closing itself #39

Closed ikornaselur closed 1 year ago

ikornaselur commented 1 year ago

Found a <br/> html tag that wasn't closing itself in one place.

I tried to run the R script to generate the json files, but it seems it has 3rd party dependencies and with my very limited (non-existant) R knowledge, I wasn't sure the best way to run it.

Tangentially I've also noticed a quote by Hunter S. Thompson that is missing a book title, as it looks like it's not a quote from a book but rather by him as a person. What's the stand on those, as it's not technically from literature? It's a quote at noon btw, I did not touch it on this branch.

netlify[bot] commented 1 year ago

Deploy Preview for fervent-tereshkova-5671fe ready!

Name Link
Latest commit 0edbb835898eb3daf464026db91bc3df422d13be
Latest deploy log https://app.netlify.com/sites/fervent-tereshkova-5671fe/deploys/632838f6a5100a0008700368
Deploy Preview https://deploy-preview-39--fervent-tereshkova-5671fe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ikornaselur commented 1 year ago

I should have realised that I could just have fixed the json file itself, as the generated output is just adding that characters as well :sweat_smile:

JohannesNE commented 1 year ago

Thanks, yeah the R script seems to be system dependent. If I have time one day, I may add a github action that runs the R script on commit.

I will also remove the Hunter S. Thompson quote.

ikornaselur commented 1 year ago

I may add a github action that runs the R script on commit.

Yeah, I was thinking that might be a nice way to do it - though I feel like it can be an annoying task as well with security implications of running scripts from forks, as scripts could be changed to log out/extract env secrets from the build environment.

I at least had a huge issue with setting up a Github Action to run properly with external user triggers (though we sorted it out at the end). I'd be happy to have a go at it btw, if it's not done later this year (as I won't have time in the next 4-5 weeks).

This also got me thinking, and maybe it's a discussion for elsewhere, but I wonder if it would make sense to create a simple platform that has a database of these quotes with CRUD-like operations where users could suggest changes/additions and be able to export the data in different ways to consume in other projects. Would make it easier to contribute and different exporters could be implemented, but obviously it would be work to set it up :smile: - It's something I want to proof of concept at some point, as it's been on my mind for a while now.