search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
598 stars 105 forks source link

13_59: fix an instance of mismatching &ldquo .. &rdquo #44

Closed artagnon closed 1 year ago

artagnon commented 1 year ago

Thanks for this wonderful site 🎉

netlify[bot] commented 1 year ago

Deploy Preview for fervent-tereshkova-5671fe ready!

Name Link
Latest commit 3c270fb38c10e637e8ed3b1c322fd1e5dfee6113
Latest deploy log https://app.netlify.com/sites/fervent-tereshkova-5671fe/deploys/637b588b9928590009962ae7
Deploy Preview https://deploy-preview-44--fervent-tereshkova-5671fe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ikornaselur commented 1 year ago

I believe these changes need to be made to the csv_to_json.R script, as these json files are generated with that script from litclock_annotated.csv

Looking at the latest change to that script in 61f6d2e7f0b2b0536ff0bbc263446e59f36a77e4 seems to show additions of those html quotations where some look correct but some do not - I'm unsure if it's a script error or the source .csv file error though, since some quotes seem to 'translate' correctly.

artagnon commented 1 year ago

Hm, the R script doesn't have anything to convert " ... " to “ ... ”", and indeed running the R script on master results in a lot of undesired changes. I wonder what I'm doing wrong. From the comment in the R script, markdown::smartypants is supposed to convert ASCII entities to HTML entities. However, the source code of smartypants doesn't have anything like this.

JohannesNE commented 1 year ago

Thanks for finding this issue! I was using an old version of the markdown package. Updating it fixed a lot, but also creates a lot of changes to quotes, that are a bit difficult to check.

It seems to fix the mismatching quotes.

See https://github.com/JohannesNE/literature-clock/pull/48

artagnon commented 1 year ago

Fixed by #48.