search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
598 stars 105 forks source link

Update {markdown} (R package) #48

Closed JohannesNE closed 1 year ago

JohannesNE commented 1 year ago

In https://github.com/JohannesNE/literature-clock/pull/44, it was noticed that the code does not reproduce the correct json files. I realized that I used an old R package and that updating it also fixed most problems in the PR.

It changes a lot of quotes since it renders as UTF8 rather than ASCII with html tags.

Leaving it here for a few days before deploying.

netlify[bot] commented 1 year ago

Deploy Preview for fervent-tereshkova-5671fe ready!

Name Link
Latest commit bc7377aae014596e8a5b0557fa3488f6379bf91b
Latest deploy log https://app.netlify.com/sites/fervent-tereshkova-5671fe/deploys/637e99330d13ba0009c9097c
Deploy Preview https://deploy-preview-48--fervent-tereshkova-5671fe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JohannesNE commented 1 year ago

I'm not too happy that it now uses 'right single quotation' for apostrophe, e.g "Iā€™m not happy". I'll try to figure that out...

JohannesNE commented 1 year ago

I'll probably also use {packrat} for package management soon.