search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
592 stars 104 forks source link

Replace backticks with quotation marks #50

Closed ikornaselur closed 1 year ago

ikornaselur commented 1 year ago

There's one other quote at 13:00 that seems to use a single backtick (Basically has: `Scarlet Pimpernel.'), which doens't get translated to a code block.. but it might be worth parsing through the csv source to make all the quotation marks consistent.

If I understand correctly, the R script should take something like "Foo" and convert it to use "fancy quotation marks", right? Is the case that there just needs to be a pass through the csv source to make all quotations marks either " or ' and the script takes care of the rest?

netlify[bot] commented 1 year ago

Deploy Preview for fervent-tereshkova-5671fe ready!

Name Link
Latest commit e1a859446ac17d8a6a469be73e645951826a2472
Latest deploy log https://app.netlify.com/sites/fervent-tereshkova-5671fe/deploys/63809f09270bc60008af56f5
Deploy Preview https://deploy-preview-50--fervent-tereshkova-5671fe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JohannesNE commented 1 year ago

Exactly. There are still a lot of non-ascii quotation marks like “ around, but ideally, the quotes should simply be in markdown, and be converted by the R-script.

Thanks for the correction.