search

JohannesNE / literature-clock

Clock using time quotes from the literature, based on the work of Jaap Meijers
http://literature-clock.jenevoldsen.com
Other
598 stars 105 forks source link

Corrections to 13:00 - Scarlet Pimpernel #60

Closed natecraddock closed 1 year ago

natecraddock commented 1 year ago

I noticed there was an ascii single quote ' instead of a unicode opening single quote ‘ for the nested quotes around Scarlet Pimpernel.

Also, the first occurrence of the word "one" is not in reference to a time, so I moved the bolding to the second occurrence.

netlify[bot] commented 1 year ago

Deploy Preview for fervent-tereshkova-5671fe ready!

Name Link
Latest commit 66bd5db4b764d109480029289edc789505fd6d07
Latest deploy log https://app.netlify.com/sites/fervent-tereshkova-5671fe/deploys/646ce73cdf5366000881cba5
Deploy Preview https://deploy-preview-60--fervent-tereshkova-5671fe.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JohannesNE commented 1 year ago

Good catch. I'm not sure how to best correct this. The JSON files are generated from a CSV file, but there is currently no way to indicate that a specific occurrence of a word (e.g. one) indicates the time. It can probably be done with an invisible html tag.

natecraddock commented 1 year ago

I hadn't realized the JSON was generated from CSV. It's probably not worth fixing it in that case. Feel free to close this!

JohannesNE commented 1 year ago

Fixed this is a somewhat hacky way by using a passive html tag (<time>one</time>) to specify the correct instance of the word.