search

John-Kibirige / tv-maze

MIT License
0 stars 1 forks source link

First task-assignment issue #20

Open John-Kibirige opened 2 years ago

John-Kibirige commented 2 years ago

Project link

https://github.com/John-Kibirige/tv-maze/projects/1

Team

We are two people on this team that is @melashu and @John-Kibirige

HAMMAS-SALEEM commented 2 years ago

Required Changes :recycle:

almost-there

Hey @John-Kibirige, @melashu :wave:

Highlights :1st_place_medal:

:heavy_check_mark: Documented work in a professional way :heavy_check_mark: Using GitHub Issues :heavy_check_mark: Descriptive Issue Title

Good job on implementing some of the requirements, there are some issues that you still need to work on to go to the next project but you are almost there! :blush:

Mandatory Changes

Screenshot from 2022-08-29 20-40-56 (copy)

Optional Suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding :clap: :clap: :clap:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @HAMMAS-SALEEM in your question so I can receive the notification. Otherwise reach out to me on slack which is more fast. You can reach out to me on slack by searching my name in full-time-students channel :+1:

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

1GORDON commented 2 years ago

Status: APPROVED 🟢

Hi @John-Kibirige & @melashu ✋

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! :tada: :clap: :clap: :100:

Highlights!

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
Cheers and Happy coding!:clap::clap::clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.