search

John-Lluch / Encoder

Arduino Rotary Encoder library using fast timer interrupts that actually works
19 stars 3 forks source link

ESP32 #11

Open robkwhitehouse opened 1 year ago

robkwhitehouse commented 1 year ago

Hi John-Lluch, This looks exactly what I need and I will give it a try. I have tried one or two other Encoder libraries and they have given problems. I am using an ESP32 running the Arduino core. I will let you know how it goes but if you are aware of any potential problems I'd be grateful if you could let me know in advance.

Many thanks for all your work.

John-Lluch commented 1 year ago

Hi Rob, thanks for your feedback. Unfortunately, I'm almost 100% sure it won't work on a ESP32. The library uses low level stuff related to the 8 bit AVR architecture only. However, I encourage you to update or submit a pull request to make it compatible with the ESP32. I'll be very happy to incorporate it in the library including a mention to your contribution.

robkwhitehouse commented 1 year ago

Hi John,

Thanks for the response. I’ve had a quick look at your code and it doesn’t look too difficult to add ESP32 support. The ESP32 timer interrupt architecture is broadly similar to the AVR. I will generate a pull request when I have tested it.

Best regards,

Bob

From: John Lluch Zorrilla @. Sent: 21 November 2022 17:50 To: John-Lluch/Encoder @.> Cc: Robert Whitehouse @.>; Author @.> Subject: Re: [John-Lluch/Encoder] ESP32 (Issue #11)

Hi Rob, thanks for your feedback. Unfortunately, I'm almost 100% sure it won't work on a ESP32. The library uses low level stuff related to the 8 bit AVR architecture only. However, I encourage you to update or submit a pull request to make it compatible with the ESP32. I'll be very happy to incorporate it in the library including a mention to your contribution.

— Reply to this email directly, view it on GitHub https://github.com/John-Lluch/Encoder/issues/11#issuecomment-1322437399 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AO56HDDIJO6TCV76343GR7TWJOY3HANCNFSM6AAAAAASGXAX5Y . You are receiving this because you authored the thread.Message ID: @.***>

hazymat commented 1 year ago

Any update on this?

robkwhitehouse commented 1 year ago

Hi @hazymat - I had a look at this and actually coded up an ESP32 version - it wasn't a lot of work. BUT I have never got around testing my ESP32 version. I have now removed the rotary encoder from my project and so I now do not need this library