search

John-P / wsic

Whole Slide image (WSI) conversion for brightfield histology images
MIT License
33 stars 4 forks source link

MPP data missing from OpenSlideReader #73

Closed himekifee closed 1 year ago

himekifee commented 1 year ago

Description

When trying to create a pyramid TIFF image from a single-level tiff image, MPP got lost in the output TIFF file.

What I Did

wsic convert -i in.tiff -o test_out.tiff -rt 4096 4096 -w 20 --no-ome --overwrite -to 180 -c jpeg -d 2 -d 4 -d 8

Note

I debugged a bit and found out this function call caused the error. Inside ppu2mpp function, the actual unit passed was "centimeter" instead of "cm" according to openslide standard. After adding "centimeter": 1e4, to L238, the output got corrected.

John-P commented 1 year ago

This should be fixed but the linked PR now