[Client] Minecraft Language setting is not respected (EC messages ignore MC setting, only respecting EC config)

[notlin4]

Description:

The mod's translation feature appears to be completely non-functional. Despite supporting translations for a wide range of languages, including Simplified Chinese (zh_cn), Korean (ko_kr), German (de_de), and French (fr_fr), among others, regardless of the language selected in Minecraft's Language settings, the mod's interface always defaults to English. No translations are being applied.

Steps to reproduce:

1. Select any language other than English in Minecraft's Language settings.
2. Observe that the mod's text remains in English.

Expected result:

The mod's text should be translated into the selected language if it's one of the supported languages.

Actual result:

The mod's text remains in English, regardless of the selected language.

Additional Information:

• Minecraft version: 1.21.1
• Essential Commands version: 0.35.2

Video Example:

The following video demonstrates the issue: https://files.catbox.moe/c8n2lo.mp4

[John-Paul-R]

Hi! First, sorry! I see that I completely lost track of your original issue, #254. Was not my intent to go radio-silent on you.

On this issue:

The translations used by Essential Commands are determined by the language property in the EssentialCommands config file. (in singleplayer, that configuration is located a the same path (config/EssentialCommands.properties), but within your .minecraft folder).

[notlin4]

Hi! First, sorry! I see that I completely lost track of your original issue, #254. Was not my intent to go radio-silent on you.

On this issue:

The translations used by Essential Commands are determined by the language property in the EssentialCommands config file. (in singleplayer, that configuration is located a the same path (config/EssentialCommands.properties), but within your .minecraft folder).

No problem! I appreciate you getting back to me.

Regarding this issue, instead of relying on the language property in the EssentialCommands config file, could you make it utilize the value specified in options.txt?

This would allow for a more centralized way to manage the game's language settings, as options.txt already handles language preferences for other aspects of Minecraft.

Thanks!

[John-Paul-R]

I'll look into it. Right now, the fact that EC works on the client is kind of a coincidence (I don't know much about client-side MC, compared to the server). But I think it should be possible. I'll use this GitHub issue to track that feature.