search

John-Paul-R / PoE-Atlas-Website

The source code for the PoE Atlas (2020-2021) website.
https://www.poeatlas.net
Mozilla Public License 2.0
2 stars 3 forks source link

Small fixes for options & localStorage #33

Open murhum1 opened 4 years ago

murhum1 commented 4 years ago

Option sliders weren't working on Firefox and I was only able to change options by clicking outside the sliders themselves, which seemed a bit silly. PR should fix this and only allow changing options by clicking on the slider itself, instead of the whole <li> element. If desired, could instead make the whole <li> element have cursor: pointer css. Tested to work on Firefox and Chrome.

Also removed debouncing on localStorage saves, as it's fast anyway and shouldn't need to be debounced. The debounce function from util.js also didn't seem to work on Firefox, while it worked fine on Chrome for some reason, but I didn't check any further.

John-Paul-R commented 4 years ago

I think making the whole <li> element have cursor: pointer would be preferred, if only to make them more easily clickable.

I'll look into possible reasons for the debounce bug on Firefox.

Thanks for the fixes! I will merge after the small <li>/slider change is added