search

John-Paul-R / PoE-Atlas-Website

The source code for the PoE Atlas (2020-2021) website.
https://www.poeatlas.net
Mozilla Public License 2.0
2 stars 3 forks source link

Hover option quirks #34

Closed murhum1 closed 3 years ago

murhum1 commented 4 years ago

Changing the "Hover Effect" option currently requires a page reload to have an effect, as the option is only read when a node is created.

If the hover option is disabled, the maps aren't clickable either, likely due to circleSprite.interactive only being set when Hover Effect is true. This and the accompanying circleSprite.buttonMode could be outside the if condition, as people will probably want to access the map sidebar even if the hover effect is disabled.

Semi-unrelated note: Should the map info sidebar be closed when an empty spot on the atlas is clicked?

John-Paul-R commented 4 years ago

Ah! I forgot to properly update the things this option affects when its updated. Thanks for the report!

If the hover option is disabled, the maps aren't clickable either, likely due to circleSprite.interactive only being set when Hover Effect is true. This and the accompanying circleSprite.buttonMode could be outside the if condition, as people will probably want to access the map sidebar even if the hover effect is disabled.

I agree, yes.

Semi-unrelated note: Should the map info sidebar be closed when an empty spot on the atlas is clicked?

I don't think so. At least, that's not the intended effect atm. Right now the goal is just to have it close only when the little 'x' is clicked. If people seem to want this, though, I'd add it as an option.

Ty for the help! o7

John-Paul-R commented 3 years ago

Fixed in df54793.