John-Smith-Modded / JSTR-Modded-1.7.x

John Smith: Technician's Remix for MC 1.7.x
https://john-smith-modded.github.io/
53 stars 42 forks source link

Loamy Dirt/Grass #134

Closed damonmensch closed 8 years ago

damonmensch commented 8 years ago

I would like to recommend we make the loamy dirt, the same tint we make the dirt portion of the loamy grass. I only suggest this to make it appear more seamless. Otherwise we get something like this... loamy dirt

I know the original modder didn't take this into consideration when he made the textures, put personally I think it's an eyesore when it stands out that much.

ScottKillen commented 8 years ago

From http://biomesoplenty.wikia.com/wiki/Loamy_Dirt:

Loamy dirt looks and functions like regular dirt, but is subtly darker in color. It can be found in some swampy or other moist biomes.

-and-

http://biomesoplenty.wikia.com/wiki/Loamy_Grass:

Loamy Grass is a block that functions the same as a regular grass block, but has a darker texture.

I would agree that the green hue seems wrong. The textures should be slightly darker than normal grass/dirt textures

Oddface commented 8 years ago

dirt_loamy grass_loamy_side These are the textures in the repo. They're the same color, but in the game they look different for some reason.

ScottKillen commented 8 years ago

Because the mod applies biome shading to the grass--which explains the green tint.

This is not something that can be fixed in the resource pack.

Oddface commented 8 years ago

It's supposed to just apply to the grass overlay and not the whole block, right? Seems like a bug.

ScottKillen commented 8 years ago

Yes, The mod is applying it to the whole texture.

ScottKillen commented 8 years ago

This should probably be reported over at the BoP repository.

Oddface commented 8 years ago

I'll just close this then.

lesdmark commented 8 years ago

That's weird mine didn't do it when I tested it.

lesdmark commented 8 years ago

Here is a screenshot from my game using BOP 2.1.0.1396 2015-11-11_22 10 05

ScottKillen commented 8 years ago

I think the textures were designed for the biome you are in. Note the first screenshot was from a Coniferous Forest...not the place that Loamy dirt/grass is normally found.