John-Smith-Modded / JSTR-Modded-1.7.x

John Smith: Technician's Remix for MC 1.7.x
https://john-smith-modded.github.io/
53 stars 42 forks source link

Create Base Pack #3

Closed goldbattle closed 10 years ago

goldbattle commented 10 years ago

Need to create a repo, and update the vanilla page downloads for JSTR vanilla packs.

Upload the patch and make sure it is up to par. See: https://github.com/John-Smith-Modded/Templates/issues/1

Current Patch: http://goo.gl/JkHxYZ

Also need to update the patch with @kardain side textures.

goldbattle commented 10 years ago

Created a repo, I hope this should do. I have tested it.

Big deal is that all the dirt matches, ctm overwrites are handled, and I think everything is on. Make sure you all check it out, should be able to use the download .zip button and just drop into your minecraft instance.

https://github.com/John-Smith-Modded/JSTR-Overwrites

kardain commented 10 years ago

Hmm.. using 1.7.2, Optifine gives a lot of hassle with CTM for most blocks (this is the only way I know of to get CTM without borking stuff up with MCPatcher). Looks like it is still wanting the numerical ID files rather than the mod:block files... might need some further investigating?

Tested against MultiMC, ATL, and vanilla launchers with just forge and optifine installed

Example error (from the overwrites in this repo):

[OptiFine] [WARN] No matchBlocks or matchTiles specified: mcpatcher/ctm/cobblestone/cobblestone_double_slab_top_bottom.properties
[OptiFine] ConnectedTextures: mcpatcher/ctm/cobblestone/cobblestone_sides.properties
[OptiFine] [WARN] Invalid number: minecraft:cobblestone, when parsing: minecraft:cobblestone
[OptiFine] [WARN] Less weights defined than tiles, expanding weights: mcpatcher/ctm/cobblestone/cobblestone_sides.properties
[OptiFine] ConnectedTextures: mcpatcher/ctm/cobblestone/cobblestone_slab_top_bottom.properties

Example success (grabbed the JS legacy version 1.2.6 as it contains the block#.properties in the CTM directories and threw just those in a temp resource pack) :

[OptiFine] ConnectedTextures: mcpatcher/ctm/cobblestone/block4.properties
[OptiFine] ConnectedTextures: mcpatcher/ctm/cobblestone/block44.properties
[OptiFine] [WARN] More weights defined than tiles, trimming weights: mcpatcher/ctm/cobblestone/block44.properties
[OptiFine] ConnectedTextures: mcpatcher/ctm/cobblestone/block4a.properties
[OptiFine] [WARN] More weights defined than tiles, trimming weights: mcpatcher/ctm/cobblestone/block4a.properties
[OptiFine] ConnectedTextures: mcpatcher/ctm/cobblestone_mossy/cobblestone_mossy_top.properties
[OptiFine] [WARN] Less weights defined than tiles, expanding weights: mcpatcher/ctm/cobblestone_mossy/cobblestone_mossy_top.properties
Shoeboxam commented 10 years ago

I wrote the CTM in Soartex to use the "matchTiles=" field, which works fine in Optifine and extends CTM to all uses of the tile in the game (even modded). I can switch the CTM over to that method while I'm fixing the other weight trimming errors and other problems I run across.

Shoeboxam commented 10 years ago

After taking a closer look, I understand why the CTM uses the "matchBlocks=" field- JSL CTM has many textures dedicated to slab and stair versions of the blocks. So I didn't touch that field.

Here's a patch that can be placed into the main download that fixes all of the errors (aside from the "matchTiles=" field, of course). http://www.mediafire.com/download/ne1d7e620ua2x12/John_Smith_Legacy_1.7.9_v1.2.17_CTM_Fixes.zip It only contains changes.

kardain commented 10 years ago

Nice. I'll check that in a bit.

Also, I was derping around on a vanilla server last night (1.7.4) that I hadn't been on in some time and noticed a couple other oddities with ctm mismatches (example, gold blocks). After the fix, I'll check again and compile a list if they are still present.

kardain commented 10 years ago

No go with the fixes using the 1.7.9 texture pack while having Optfine handle the CTM

The latest version that I can get to work with both the overwrites and the fixes you provided on 1.7.2 is v1.2.11 for 1.7.5. It is appearing that Mojang or MCP changed how the connected texture handlers work (at least the properties files themselves, and folder structure in some instances). A quick glance through v1.2.11 compared to v1.2.17 (using Meld to compare), stained glass works with folder glass_(color) rather than the newest version of stainedglass(color); wool works with folder name wool instead of wool_white.

Netherbrick works using block112.properites (also 112a, 44, and 44a in place of the 112) rather than netherbrick(side).properties

There are quite a few more differences, these were just the notable ones.

Though with a 1.7.9 version of forge forthcoming sometime in the eventual maybe future, this issue may be moot in the end https://twitter.com/minecraftcpw/status/469187935988748288

goldbattle commented 10 years ago

I think this is as good as it will get for a while. The overwrite repo can host pull request/commits to make this better if needed.