search

John-Smith-Modded / JSTR-Modded-1.7.x

John Smith: Technician's Remix for MC 1.7.x
https://john-smith-modded.github.io/
53 stars 42 forks source link

BluePower Updates #63

Closed damonmensch closed 9 years ago

Oddface commented 9 years ago

We recently made a change to how we do ingots and gems. You might be using an older version of the pack as a reference point. Just download the newest version and try to match that instead. Other than those minor problems, great work!

ScottKillen commented 9 years ago

The purple amethyst color is truer to the original mod textures (which are a deep purple). Why the change to pink? Also, to me, the pink is very bright and does not seem to fit well in-game.

At the very least perhaps don't delete the purple, but offer them as alternates (see how this is done for with other mods in this repo)

Oddface commented 9 years ago

He was matching it to the BoP amethyst, which is pink. It's an issue about resource pack consistency vs consistency with the default textures. It's not always easy to know where to draw the line. If there isn't an ore dictionary entry for the two amethyst types, that essentially makes them the same thing, I would vote purple. We should not do alternates in this case because there are tools and stuff that would also have to have alts to keep consistency.

ScottKillen commented 9 years ago

I forgot about tools...and I sorta created this controversy only providing block textures and not items.

I prefer the purple, but I hate to ask@damonmensch redo so many textures. Unless @Oddface pushes for the purple, I withdraw my remarks and will handle my personal preference through overrides.

Also, @damonmensch , I forgot to mention that these textures are very well done. :+1: to you/

Oddface commented 9 years ago

Don't worry about it. The pink amethyst stuff can stay for now and if you end up making purple versions you can commit that later.

damonmensch commented 9 years ago

Yeah sorry this was done porting the older, I'll alter the ingots to match the new style later today/tonight and send a new commit. I wasn't aware the gems were changed. Again the amethyst was taken from BoP, the other gems were done from the old RedPower2 versions. I'll check the gems as well.

Edit: Also personally I feel being as consistent as possible across mods, especially ore dictionary items, is a better plan than true to original textures. If we decide to push for the purple instead let me know. FYI the only things I really did myself were the gates which was a color change and slicing of the RedPower2 port. Just about everything else was either also ported from RedPower2 or another mod that had the same item.

Oddface commented 9 years ago

:+1:

damonmensch commented 9 years ago

Updated the ingots and gems to match the new standards. Got to say the hue swap on them came out nicely.

Also may I suggest adding the new gem templates to the templates repository? Also maybe we should add some of the mod ores as well, if anyone happens to have the overlays.

Oddface commented 9 years ago

Nice work!