JohnAdders / climate_narrative

CBES/NGFS scenario analysis narrative tool to support smaller firms
MIT License
3 stars 7 forks source link

Technical comments #231

Closed krzmip closed 2 years ago

krzmip commented 2 years ago

From Nicolas Lancesseur, 1 On the “Report type selection” page, it would be useful for users to have one or two lines explaining the difference of approach between institutional report and sector report (for instance something like “if you want to generate a report depending on your own sectoral and geographical exposure”, “if you want to access the complete risk assessment for a sector or a country”, etc.) 2 For the institutional report, the inputs that the user needs to provide could be shortly specified for more clarity 3 The download button does not allow the user to save the report because of a typo in the address (“htm” instead of “html”). 4 Using two separate windows of the tool seems to dysfunction 5 In the NGFS Disorderly scenario presentation at the beginning of each report including this scenario, there is a typo: “In Disorderly transition risk scnearios” 6 Formal sectors should be distinguished from sovereign issuers for more clarity 7 For the institutional report, the users can select only one scenario among the three available in the tool. A command could be added to provide an institutional report including all the scenarios. 8 Once the user clicks on the source or reference link, if he/she did not open it in a new tab the previous report cannot be recovered without starting the process again

krzmip commented 2 years ago

Triaged

Solved (in develop branch so far): points 1 and 5

Possible to address relatively quickly: point 7.

More info required, no actions for now

  1. Clarification required. I would say the inputs (exposure materialities) are shortly specified in help text in respective tabs
  2. Seems to work fine in my context. More details required (in particular the browser used) to identify the issue
  3. Confirmed. This is probably an inherent limitation of the tools used, or at least I am not aware how to make multiple independent instances in a single browser
  4. Agreed that both sectors and countries serve the same purpose (discriminate the exposures of the undertaking, for equities/corporates and sovereigns respectively). But not clear what exactly "distinguish" in this context would means and whether it makes sense to make a change
  5. Seems to work fine in my context. The links are meant to open in the new tab. It is possible though that it does not work for all browsers, devices, configurations
krzmip commented 2 years ago

update re 8: all links in the tool contents checked, in some cases indeed new tab was not enforced, which was fixed re 7: lack of such report is intentional

krzmip commented 2 years ago

closing note:

1 solved by adding several lines of description on the report type selection page 2 solved. included in the description mentioned above 3 not solved. Download feature works correctly in our configuration, probably a specific browser/configuration/environment problem which we are not able to reproduce 4 not easy to solve. remediated by adding a notice below the disclaimer 5 solved 6 the label of the select input in the report page modified, instead of "sector" mentions "sector/asset class" (institutional report for banking, asset managers) or "sector/asset class/liability class" (iinstitutional report for insurance, sector report) 7 not solved. as discussed with John this was deliberate design choice to allow single scenario report only 8 solved. all links should open in a new tab now. However, it is not impossible that for some browser/configuration it does not work as expected

krzmip commented 2 years ago

update: point no 4 logged as a separate issue #236