search

JohnAlbin / chroma

Chroma: The Sass color manager
http://johnalbin.github.io/chroma/
GNU General Public License v2.0
40 stars 7 forks source link

Chroma kss markup is causing an Error with scss-lint #13

Closed sarahjean closed 8 years ago

sarahjean commented 9 years ago

Trying out a zen 7.6 subtheme, so I wasn't sure whether to report this here or over there, but scss-lint/gulp-scss-lint seems to be choking on these lines:

// scss-lint:disable Comment
/*
#{chroma-kss-markup()}
*/

I had to run the gulp task in verbose mode and then run that output straight on the command line to track it down, the gulp error was 'internal software error'. This is the error i am seeing:

SCSSLint::Linter::SpaceBetweenParens raised unexpected error linting file /path//to/sass/style-guide/chroma-kss-markup.scss: 'undefined methodcount' for nil:NilClass'`

JohnAlbin commented 9 years ago

Yep, I was seeing the same thing on Friday. It's a bug in sass-lint. https://github.com/brigade/scss-lint/issues/568

JohnAlbin commented 9 years ago

@sarahjean If you add these lines to the end of your .scss-lint.yml file, it should work-around the bug in scss-lint.

  # scss-lint 0.41.0 dies parsing chroma-kss-markup.scss when using SpaceBetweenParens
  # See https://github.com/brigade/scss-lint/issues/568
  SpaceBetweenParens:
    enabled: false
sarahjean commented 9 years ago

It did indeed, thanks!

JohnAlbin commented 9 years ago

Cool!

I'll keep this ticket open to track the scss-lint bug and close it out when the bug is fixed.

JohnAlbin commented 8 years ago

Upstream issue is fixed. Need to confirm the work-around is no longer needed.

JohnAlbin commented 8 years ago

The work-around is no longer needed.