search

JohnAlbin / normalize-scss

This is the Sass version of Normalize.css, a collection of HTML element and attribute rulesets to normalize styles across all browsers.
https://github.com/JohnAlbin/normalize-scss#latest-versions
MIT License
1.44k stars 254 forks source link

Problem with adjust-leading-to() in new version. #14

Closed jamesscholeyweb closed 11 years ago

jamesscholeyweb commented 11 years ago

Hi John not sure where else to turn. I usually use a base line height of 6px and adjust leading to (4) on html to give me better control over white space. Just updated to the latest version of normalize scss and its setting the line-height to 6em rather than calculating 1.5em.

Tested with the old version in case it was my version of compass and worked fine. I notice you added the strict normalize boolean in but I can't see how that should affect the outcome.

Any thoughts would be much appreciated.

In fact just tested with default of leading(1) and no matter what I change the base-line-height variable to it always outputs 1.5em???

jamesscholeyweb commented 11 years ago

Sorry John just tested with vanilla normalize and getting same so something in my setup somewhere. Cheers

jamesscholeyweb commented 11 years ago

Just for reference I discovered the problem was the !default on the base-line-height variable seems for some reason it gets ignored. Once I removed the !default it works fine. Not sure why.

JohnAlbin commented 11 years ago

If the problem was with !default, I suspect you have a very old version of Sass installed.

jamesscholeyweb commented 11 years ago

Morning John, just checked my gems, running Sass 3.2.9 and Compass 0.12.2. I was under the impression that if you add !default to a variable and it already has a value assigned it will keep the the initial value and not assign a new one unless its value is null. I was unsure whether your intention was to keep the !default statement in Normalize.scss variables or to remove it when changing to a new value? which is what I have been doing to enable the value to to be changed by compass vertical rhythm. So if the default value set by compass is $base-line-height:24px and the normalize variable is set to $base-line-height: 22px !default it will not overwrite the initial 24px unless you drop the !default statement.

jamesscholeyweb commented 11 years ago

Sorry John, solved it. My bad as I suspected :). I was pulling in compass before my variables partial instead of afterwards.