search

JohnAlbin / normalize-scss

This is the Sass version of Normalize.css, a collection of HTML element and attribute rulesets to normalize styles across all browsers.
https://github.com/JohnAlbin/normalize-scss#latest-versions
MIT License
1.44k stars 254 forks source link

$strict-normalize doesn't seem to work as intended #33

Closed bhrutledge closed 9 years ago

bhrutledge commented 10 years ago

It's almost always used liked this:

@if not $strict-normalize or support-legacy-browser(ie, "7") {
  // Vertical rhythm code...
}

Since support-legacy-browser returns true, the vertical rhythm code gets included. I'm not sure what the expected behavior is, but the result is $strict-normalize is essentially ignored.

JohnAlbin commented 9 years ago

support-legacy-browser(ie, "7") only returns true if you leave Compass' settings as the default. Since compass includes IE7 support due to its current usages statistics.

normalize-scss assumes that if you want IE7 support than that is more important than your request for $strict-normalize.

If you change the defaults so that IE7 is not supported, then the $strict-normalize will control the output as expected.