search

JohnAlbin / normalize-scss

This is the Sass version of Normalize.css, a collection of HTML element and attribute rulesets to normalize styles across all browsers.
https://github.com/JohnAlbin/normalize-scss#latest-versions
MIT License
1.44k stars 254 forks source link

Undefined variable: "$px-fallback". #45

Closed andrewfleming closed 9 years ago

andrewfleming commented 9 years ago

From a fresh Bower install, and import of the normalize.scss files the following error is returned

Error: Undefined variable: "$px-fallback".
    on line 42 of bower_components/normalize-scss/fork-versions/default/_vertical-rhythm.scss, in `normalize-rhythm'
    from line 58 of bower_components/normalize-scss/fork-versions/default/_vertical-rhythm.scss, in `normalize-margin'
    from line 185 of bower_components/normalize-scss/fork-versions/default/_normalize.scss
    from line 2 of sass/style.scss
vwochnik commented 9 years ago

Ha! I have the same problem on my Jekyll installation. Hope someone can fix this.

JohnAlbin commented 9 years ago

I'm still trying to work out how the tests for normalize-scss didn't catch this. They should have caught a hard error.

Are you 2 using Ruby Sass or libSass/node-sass ?

andrewfleming commented 9 years ago

I'm compiling via Grunt Contrib Sass which I believe uses Ruby Sass as it's Readme says it's required.

JohnAlbin commented 9 years ago

Yeah, the tests are using node-sass. Guh. It must have a scoping bug where it doesn't match the Ruby implementation. Sorry about that!

I'll roll a 4.0.3 version as soon as I fix #47.

vwochnik commented 9 years ago

Well, you have fixed #47, can you please bump up the versions so I can get rid of my workaround?

vwochnik commented 9 years ago

@JohnAlbin btw why is this a fork of normalize.css? I've looked at it the repository is completely different. I would suggest detaching the fork.

To detach the fork and turn it into a standalone repository on GitHub, contact GitHub support.

-- GitHub Help

JohnAlbin commented 9 years ago

btw why is this a fork of normalize.css

Well, it is a fork of normalize.css. The last time there was a release of normalize.css, I just merged the commits into this repo.

Does it matter? I can do the merging of the commits regardless of whether it says "forked from necolas/normalize.css" at the top of the page or not.

can you please bump up the versions so I can get rid of my workaround?

Done!