search

JohnAlbin / normalize-scss

This is the Sass version of Normalize.css, a collection of HTML element and attribute rulesets to normalize styles across all browsers.
https://github.com/JohnAlbin/normalize-scss#latest-versions
MIT License
1.44k stars 254 forks source link

Only assign Typey variables if not already assigned #72

Closed idpaterson closed 8 years ago

idpaterson commented 8 years ago

Attempting to use the typey fork directly from the normalize-scss npm module I noticed that my typey settings were overridden. This change uses the !default flag to only assign defaults in the typey and default fork versions. Note that the ruby-sass-compass fork version already uses !default.

In the case of typey I purposely omitted the !default flag on $normalize-vertical-rhythm since typey handles vertical rhythm and this variable is not used in this particular fork version.

Please let me know if you would like tests for overriding the defaults. If so I will add input-customized.scss and output-customized.css fixtures for typey. However, customization does not seem to be included in other tests.

JohnAlbin commented 8 years ago

Attempting to use the typey fork directly from the normalize-scss npm module

Hmm… I hadn't thought people would use it that way. I thought they would, you know, fork it by copying the files somewhere and making changes directly.

But I guess the lack of !default harms your (surprising to me) usage and has no real effect on those who actually fork the files.

idpaterson commented 8 years ago

Thanks for reviewing.