Ingame rename command. Usable only once.

JohnAnthony / TROG

ncurses roguelike done right.

Other

22 stars 3 forks source link

Ingame rename command. Usable only once. #10

Closed alcioa closed 12 years ago

alcioa commented 12 years ago

Avoiding confusion, neuro is my linux user =)

JohnAnthony commented 12 years ago

Regarding 5c612da, why would you limit name changes to only once? The name change option should be inside the CHARACTER_SCREEN game mode as giving a name change option a whole game mode is bad design. I don't have any particular preference about bracing style, but we already have 5k LOC here using a particular style so please stay in the style in which the project has been written.

notwa commented 12 years ago

Why not have a book or another item that would allow you to change your name? If you find it and want to use it, you can, otherwise you could just drop it.

JohnAnthony commented 12 years ago

I just don't see changing your character's name as a major event that requires special equipment or as something thta should be arbitrarily limited.

alcioa commented 12 years ago

What do I do with this PR ?

JohnAnthony commented 12 years ago

Rework it or close it. Up to you.