JohnBrodie / pyjector

Library to help control your projector over a serial connection
MIT License
50 stars 19 forks source link

Epson Projector #14

Open martimarkov opened 7 years ago

martimarkov commented 7 years ago

I'm building a config for my epson projector but I have an issue the commands for status are without a separator. For example:

PWR ON\r -> powers the projector on PWR OFF\r -> powers the projector off PWR?\r -> gets the status

There is no space between PWR and ?.

Have you had this problem previously?

andrej-peterka commented 6 years ago

I actually hit the same problem and implemented a fix in my fork.

This is the relevant commit... https://github.com/andrej-peterka/pyjector/commit/c2d11959b36c286f61ece6e619deb20adb7e0d79.

There are some other changes in my code which I need, but I'd be happy to cherry pick and make a PR if someone thinks it'd be useful.

JohnBrodie commented 6 years ago

@andrej-peterka - Feel free to make a PR if/when you're done your changes. It's been quite a while since I've touched this, happy to get new features/fixes/improvements in though.