search

JohnCoates / Aerial

Apple TV Aerial Screensaver for Mac
MIT License
20.78k stars 1.05k forks source link

wrong preview image #1228

Closed 0x5e closed 2 years ago

0x5e commented 2 years ago

image image

glouel commented 2 years ago

Hey @0x5e

This can happen when the previews are generated, usually it fixes itself as you scroll around. When all the previews have been generated (this depends on your network connections) it shouldn't be an issue again.

0x5e commented 2 years ago

Hi @glouel , This is a simple issue often appears on iOS Apps. I can help fix this when I'm free. I'm in China and download takes a long time, this issue will make app experience really terrible.

glouel commented 2 years ago

Yep if you think you can help fix it, don't hesitate if you have some time to do so.

I think the problem is especially complicated in China as Apple servers are either slow or blocked. The thumbnails are generated by fetching the beggining of each file and that can take a lot of time in that case. Thanks !

Thanks for offering to help in any case, take care

0x5e commented 2 years ago

https://github.com/JohnCoates/Aerial/blob/c2a93e3240cefd1f0be2ef4c6d57cac2cfd10a5f/Resources/MainUI/VideosViewController.swift#L725-L732

In the Thumbnails.get complete block, the cell may be reused. Maybe we can add a cell.video == video protection here?