Symlinked video ignored in 3.3.8

i0ntempest commented 2 months ago

General troubleshooting tips

Before logging an issue please check that:

[x] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[x] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[x] Your problem isn't mentioned in the troubleshooting page.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.

Required information

In order to help us sort your issue, we ask that you provide the following information:

[ ] Mac model: Mac Studio M2 Ultra
[ ] macOS version: 14.4.1
[ ] Monitor setup: 3*1440P

If appropriate, please enable Debug mode and Log to disk in Advanced tab and replicate your bug, then attach the AerialLog.txt file (You can access this file through the Advanced tab).

Description of issue / Feature request

I have a folder with symlinks to videos I want to use as screen saver. Before 3.3.8 this worked great. I think it's the new file size check in 3.3.8 breaking this as symlinks are obviously very small. Log file: AerialLog.txt

glouel commented 2 months ago

Hi @i0ntempest

Ha, that's an... unfortunate side effect of my latest attempt at a fix, yes :(

I'll try to see if I can detect symlinks and ignore those in my checks, will keep you posted.

Just curious, why are you symlinking though and not adding that folder directly ?

i0ntempest commented 2 months ago

Well, my main video folder has a lot of random stuff and only part of them I want as my screen saver. I'm using symlinks to save disk space. Also instead of detecting symlinks I think you can just skip the check for all local sources, where no downloads are involved and users should make sure video files are valid?

glouel commented 2 months ago

Ok !

And Indeed, checking for local source should be a much easier fix. I"ll try to make a fix this week end, in the meantime stick to 3.3.7.

Thanks for the report, will keep you posted!

JohnCoates / Aerial