[Overlays-Clock]:Clock 24-hour format conversion in Overlays is still 12-hour format.

leijunCN commented 1 month ago

General troubleshooting tips

Before logging an issue please check that:

[ ✅ ] You have the latest version installed (There may be a beta version that fixes your issue), see here for the latest releases and bug fixes: https://github.com/JohnCoates/Aerial/releases
[ ✅ ] Your issue isn't already mentioned in our issues. You may find a workaround there or a similar request already made.
[ ✅ ] Your problem isn't mentioned in the troubleshooting page.

If none of this fixes your issue, tell us about the problem you are experiencing or the feature you'd like to request.

Required information

In order to help us sort your issue, we ask that you provide the following information:

[ ✅ ] Mac model: MacBookPro 14 (M1Pro)
[ ✅ ] macOS version: 12.7.5
[ ✅ ] Aerial version: 3.3.8

If appropriate, please enable Debug mode and Log to disk in Advanced tab and replicate your bug, then attach the AerialLog.txt file (You can access this file through the Advanced tab).

Description of issue / Feature request

Hello, John!

Thank you very much for the software you developed. I like it very much. In the course of using it, I found a small bug that failed to display the 24-hour format as expected when the clock format was converted to 24 hours (eg: 3:00 PM = > 15:00). I hope you can fix it when you are free.

In addition, there is a small functional optimization that we hope will be adopted in future functional iterations. I have noticed that the "week" in "date" is normally localized in the simplified Chinese I use (eg: Sunday = >"星期日"), but the AM/PM of the clock is not localized as "上午 (morning) / 下午 (afternoon)". This is very helpful to me, and I hope you can add this feature in future updates.Or I want to be able to provide a Functional configuration, because the current custom configuration does not meet my needs.

Finally, thank you very much. Good luck!

glouel commented 1 month ago

Hi @leijunCN

I'm Guillaume and I'm the one maintaining Aerial nowadays. Clock and localization can be weird because this also depends on your macOS system settings.

I'll try to have a look and keep you posted, but in the meantime, can you give me for say, 20:25, how is it displayed in Aerial, and how macOS shows it to you elsewhere ?

Thanks !

leijunCN commented 1 month ago

Hi, Guillaume

Thank you very much for responding to my issue. Let me first describe the current situation.

MacOS

12 hours : 下午 8:25 24 hours: 20:25

Aerial

12 hour : 8:25 PM 12 hour (Hide AM/PM ): 8:25

24 hour : 8:25 PM 24 hour (Hide AM/PM ): 8:25

Yes, The display effect of 24 hours and 12 hours is the same ,The configuration of 'Hide AM/PM' is also shared.Please fix this bug.

Good luck！

JohnCoates / Aerial