search

JohnCoene / cicerone

🏛️ Give tours of your Shiny apps
https://cicerone.john-coene.com
Other
187 stars 7 forks source link

Auto-detection of id/class #35

Closed yogat3ch closed 2 years ago

yogat3ch commented 2 years ago

Hi @JohnCoene, Hope you're doing well! I haven't had a chance to do the tidy evaluation for echarts4r as I realized that was a heftier undertaking than I had anticipated! However, I am finding that there's some minor changes to the Cicerone step function that would make it more intuitive that can be easily added. One of these being the auto-detection of the id/class based on the selector format (prefixed by ./#). Can I send you a PR for this?

JohnCoene commented 2 years ago

We can do that but we have to take into account is_id argument: https://github.com/JohnCoene/cicerone/blob/4791dd6f411e2aec765f8e38522e7c4b9085fe16/R/steps.R#L106

And have to do it in such a way thatit does not break existing apps.

Feel free to submit a PR

yogat3ch commented 2 years ago

Thanks for the prompt response! Indeed, I think it observes this but the continuous integration will be the ground truth on that.

36 is submitted.

yogat3ch commented 2 years ago

Closed with #36