Element detection & alternative arg names (from driver.js)

yogat3ch commented 2 years ago

Auto-detects whether to prepend #, sets is_id if el/element begins with .

this was a gotcha when first getting started as one anticipates the selector to work like JS/CSS (IE # is used to indicate an ID) Add alternative argument names that correspond with those passed to driver.js (and stored internally in the R6). This adds a dependency on rlang::%||%. I've only added the arguments we're currently using but there's room for additional. Possibly in a future PR if we have a need for them.

yogat3ch commented 2 years ago

Hey @JohnCoene I think this one is ready to go now provided your approval

JohnCoene commented 2 years ago

Thanks looks good @yogat3ch

Do you want to add yourself as ctb to the DESCRIPTION before I merge?

yogat3ch commented 2 years ago

Do you want to add yourself as ctb to the DESCRIPTION before I merge?

Sure, thanks for the invitation to do so! Just did in 1eae3e3

A pleasure working with you on this!

JohnCoene commented 2 years ago

Thank you!

JohnCoene / cicerone