JohnCoene / echarts4r

🐳 ECharts 5 for R
http://echarts4r.john-coene.com/
Other
592 stars 81 forks source link

group_by + e_lm doesn't work correctly #377

Open jyjek opened 2 years ago

jyjek commented 2 years ago

Example return wrong lm line

iris |> 
  group_by(Species) |> 
  e_charts(Sepal.Length) |> 
  e_line(Sepal.Width) |> 
  e_lm(Sepal.Width ~ Sepal.Length) |> 
  e_x_axis(min = 4)

image Same code with ggplot

iris %>% 
    ggplot(aes(x = Sepal.Length, y = Sepal.Width, fill = Species)) + geom_point() +
    geom_smooth(method='lm', formula = 'y ~ x') 

image

munoztd0 commented 1 year ago

This look like it has been fixed in #396

library(echarts4r)

plot <- iris |> 
  group_by(Species) |> 
  e_charts(Sepal.Length) |> 
  e_line(Sepal.Width) |> 
  e_lm(Sepal.Width ~ Sepal.Length) |> 
  e_x_axis(min = 4)

plot

Created on 2023-03-07 with reprex v2.0.2.9000

Session info ``` r sessioninfo::session_info() #> ─ Session info ─────────────────────────────────────────────────────────────── #> setting value #> version R version 4.1.2 (2021-11-01) #> os Ubuntu 22.04.2 LTS #> system x86_64, linux-gnu #> ui X11 #> language (EN) #> collate en_US.UTF-8 #> ctype en_US.UTF-8 #> tz Europe/Zurich #> date 2023-03-07 #> pandoc 2.19.2 @ /usr/lib/rstudio/bin/quarto/bin/tools/ (via rmarkdown) #> #> ─ Packages ─────────────────────────────────────────────────────────────────── #> package * version date (UTC) lib source #> echarts4r * 0.4.4 2022-05-28 [1] CRAN (R 4.1.2) #> ellipsis 0.3.2 2021-04-29 [1] CRAN (R 4.1.2) #> evaluate 0.19 2022-12-13 [1] CRAN (R 4.1.2) #> fansi 1.0.3 2022-03-24 [1] CRAN (R 4.1.2) #> fastmap 1.1.0 2021-01-25 [1] CRAN (R 4.1.2) #> fs 1.5.2 2021-12-08 [1] CRAN (R 4.1.2) #> generics 0.1.3 2022-07-05 [1] CRAN (R 4.1.2) #> glue 1.6.2 2022-02-24 [1] CRAN (R 4.1.2) #> highr 0.10 2022-12-22 [1] CRAN (R 4.1.2) #> htmltools 0.5.4 2022-12-07 [1] CRAN (R 4.1.2) #> htmlwidgets 1.6.1 2023-01-07 [1] CRAN (R 4.1.2) #> httpuv 1.6.9 2023-02-14 [1] CRAN (R 4.1.2) #> knitr 1.41 2022-11-18 [1] CRAN (R 4.1.2) #> later 1.3.0 2021-08-18 [1] CRAN (R 4.1.2) #> lifecycle 1.0.3 2022-10-07 [1] CRAN (R 4.1.2) #> magrittr 2.0.3 2022-03-30 [1] CRAN (R 4.1.2) #> mime 0.12 2021-09-28 [1] CRAN (R 4.1.2) #> pillar 1.8.1 2022-08-19 [1] CRAN (R 4.1.2) #> pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 4.1.2) #> promises 1.2.0.1 2021-02-11 [1] CRAN (R 4.1.2) #> purrr 1.0.0 2022-12-20 [1] CRAN (R 4.1.2) #> R.cache 0.16.0 2022-07-21 [2] CRAN (R 4.1.2) #> R.methodsS3 1.8.2 2022-06-13 [2] CRAN (R 4.1.2) #> R.oo 1.25.0 2022-06-12 [2] CRAN (R 4.1.2) #> R.utils 2.12.2 2022-11-11 [2] CRAN (R 4.1.2) #> R6 2.5.1 2021-08-19 [1] CRAN (R 4.1.2) #> Rcpp 1.0.10 2023-01-22 [1] CRAN (R 4.1.2) #> reprex 2.0.2.9000 2023-03-07 [1] Github (tidyverse/reprex@77ec1f6) #> rlang 1.0.6 2022-09-24 [1] CRAN (R 4.1.2) #> rmarkdown 2.19 2022-12-15 [1] CRAN (R 4.1.2) #> rstudioapi 0.14 2022-08-22 [1] CRAN (R 4.1.2) #> sessioninfo 1.2.2 2021-12-06 [1] CRAN (R 4.1.2) #> shiny 1.7.4 2022-12-15 [1] CRAN (R 4.1.2) #> stringi 1.7.8 2022-07-11 [1] CRAN (R 4.1.2) #> stringr 1.5.0 2022-12-02 [1] CRAN (R 4.1.2) #> styler 1.8.1 2022-11-07 [2] CRAN (R 4.1.2) #> tibble 3.1.8 2022-07-22 [1] CRAN (R 4.1.2) #> tidyr 1.2.1 2022-09-08 [1] CRAN (R 4.1.2) #> tidyselect 1.2.0 2022-10-10 [1] CRAN (R 4.1.2) #> utf8 1.2.2 2021-07-24 [1] CRAN (R 4.1.2) #> vctrs 0.5.1 2022-11-16 [1] CRAN (R 4.1.2) #> withr 2.5.0 2022-03-03 [1] CRAN (R 4.1.2) #> xfun 0.36 2022-12-21 [1] CRAN (R 4.1.2) #> xtable 1.8-4 2019-04-21 [1] CRAN (R 4.1.2) #> yaml 2.3.6 2022-10-18 [1] CRAN (R 4.1.2) #> #> [1] /home/david/R/x86_64-pc-linux-gnu-library/4.1 #> [2] /usr/local/lib/R/site-library #> [3] /usr/lib/R/site-library #> [4] /usr/lib/R/library #> #> ────────────────────────────────────────────────────────────────────────────── ```

image