search

JohnCoene / echarts4r

🐳 ECharts 5 for R
http://echarts4r.john-coene.com/
Other
595 stars 81 forks source link

Pass group variables without using dplyr #496

Closed AdrianAntico closed 1 year ago

AdrianAntico commented 1 year ago

Is there a way to pass group variables to escatter with timeline=T without using a dplyr::group_by to pass data?

JohnCoene commented 1 year ago

No there is not, why do you want to do differently?

AdrianAntico commented 1 year ago

As a package creator myself, I try do my best to limit outside dependencies and dplyr is a big one, coming with a ton of other dependencies. Aside from that, data.table is almost always a better option, if you have to go there.

Their only dependency is the bit64 package, it's a faster processing engine, and it uses less memory for the same data set sizes and characteristics. dplyr has had backwards compatibility issues where data.table does not, which could mean less maintenance from your end.

Lastly, I think you can add a parameter that simply requests the info supplied by group_by. It appears that the only thing different is that is contains some metadata about the unique levels from the group variables, which could easily be passed via a new parameter.

JohnCoene commented 1 year ago

Yes, I appreciate that but {dplyr} is a hard dependency of the package anyway. You could mimic group by (it's just an attribute or something like)

https://github.com/JohnCoene/echarts4r/blob/bddcb361fa983bab00fba0545c42d6de162e90d6/DESCRIPTION#L21