JohnCoene / echarts4r

🐳 ECharts 5 for R
http://echarts4r.john-coene.com/
Other
595 stars 81 forks source link

Error with upcoming `countrycode` version #527

Closed vincentarelbundock closed 1 year ago

vincentarelbundock commented 1 year ago

I am the countrycode maintainer and will release a new minor version soon. There are no breaking changes, and I did not expect any breakage in downstream packages. However, when doing reverse dependency checks, I ran into an error in the echarts4r test suite.

Pasting the error below to inform you:

Changes to worse in reverse depends:

Package: echarts4r
Check: tests
New result: ERROR
    Running ‘testthat.R’ [4s/4s]
  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
> library(testthat)
> library(echarts4r)
> 
> test_check("echarts4r")
    [ FAIL 1 | WARN 14 | SKIP 0 | PASS 180 ]

    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure ('test-map.R:21:3'): e_map plot has the good data structure and type ──
    plot$x$opts$series[[1]]$data not equal to list(...).
    Component 2: Component 2: 1 string mismatch
    Component 3: Component 2: 1 string mismatch
    Component 4: Component 2: 1 string mismatch
    Component 5: Component 2: 1 string mismatch

    [ FAIL 1 | WARN 14 | SKIP 0 | PASS 180 ]
    Error: Test failures
    Execution halted
JohnCoene commented 1 year ago

Thank you, got email from CRAN too. Will fix.

munoztd0 commented 1 year ago

Commit b1eac68 fixed this