search

JohnCoene / echarts4r

🐳 ECharts 5 for R
http://echarts4r.john-coene.com/
Other
600 stars 81 forks source link

Add depth param support to e_sankey #89

Open artemklevtsov opened 5 years ago

artemklevtsov commented 5 years ago

Helpful to control layout.

JohnCoene commented 5 years ago

Yes indeed, thanks again Artem. However I wanted to keep things simple for the sankey chart and thus the user is essentially asked to only pass edges, nodes are inferred from the latter. I am unsure what the best solution to this is, perhaps create two other functions that allow more control (e_sankey_nodes and e_sankey_edges)?

Keen on your input.

artemklevtsov commented 5 years ago

According documentation depth relies to data array. So we should handle it (if exists) in the .build_sankey_nodes.

artemklevtsov commented 5 years ago

About e_sankey_nodes and e_sankey_edges. I think this is not a bad idea. Although, right now there is no need for this.

JohnCoene commented 4 years ago

Maybe @helgasoft's solution for the treemap could be applied here