search

JohnCoene / javascript-for-r-comments

1 stars 0 forks source link

piety dependencies #10

Closed MayaGans closed 4 years ago

MayaGans commented 4 years ago 
dir.create("./inst/htmlwidgets/jquery", recursive = TRUE)
dir.create("./inst/htmlwidgets/typed")

Why do we use recursive = TRUE for jquery? Does this allow us to import all the files within a directory? Also - is the second directory a typo? typed should be piety? Am I missing something?

JohnCoene commented 4 years ago

Ah lord, well spotted!

That's clearly wrong, it should indeed be:

dir.create("./inst/htmlwidgets/jquery")
dir.create("./inst/htmlwidgets/peity")

Thank you, I have fixed that in the book (not re-rendered yet) :)

JohnCoene commented 4 years ago

I closed that quick, sorry.

For context, I changed the entire chapter recently, it previously featured typed.js but according to reviewers caused confusion because this part of the book deals with "Visualisation" and this is just an animation: I thought it was fair and changed to another library :)