search

JohnCoene / javascript-for-r

📚 JavaScript for R CRC Book
https://javascript-for-r.com/
Other
181 stars 46 forks source link

License about Highcharts #4

Open yutannihilation opened 3 years ago

yutannihilation commented 3 years ago

I'm not a license expert, but let me quickly share my concern about using Highcharts in an R package. As you probably already notice, the license of Highcharts is a bit tricky in that it depends on where it's used. This means, it's not the developer of the package but the user of the package who needs to care about the license. IIUC, the user needs to get the license on Highsoft's website, and consider whether it's "non-commercial use" before actually using it (I'm not even sure if it's "non-commercial use" to use the screenshot in a published book...). This seems too complex to recommend for the ordinary users, so I'm afraid the book should not refer to Highcharts to avoid confusion.

To be clear, I like Highcharts, and I might choose it if it's a personal website that I'll create, but I'm just afraid the licensing is not suitable for R packages.

JohnCoene commented 3 years ago

Sorry for the late response.

Yes indeed you are correct on the license; Joshua Kunst the author of highcharter also makes that very clear with the message printed on package startup.

I refer to highcharts because it is a very popular library, particularly in the R community and oughts to be named, I do mention the issue with the license but probably should be clearer about; I'll edit the book to make this more transparent.

yutannihilation commented 3 years ago

Thanks, sounds good to me.