search

JohnCoene / waiter

🕰️ Loading screens for Shiny
https://waiter.john-coene.com/
Other
499 stars 25 forks source link

BUG: waitress notification progress bar position is not responsive #54

Open lz100 opened 4 years ago

lz100 commented 4 years ago

The progress bar is fixed at a certain window location. It is not responsive. If I scroll or enlarge the window, the progress bar is not moving with the notification bar.

not_moving

I inspected the html and it comfirms: html You can see the left, top of notification div is set to auto but the progress bar div is set to a fixed number

This is my code to start waitress

    progress <- Waitress$new(theme = "overlay-opacity",
                             min = 0, max =10)
    progress$notify(
        html = "Validating",
        position = "br",
        text_color = "blue"
        )
# I have some other code to update the loop
# ...

Is this a bug?

lz100 commented 4 years ago

I tested with your waitress demo and found the same thing. I think it is not special to my code. demo_screenshot

I can see the progress bar goes off if I scroll the page when it is running.

JohnCoene commented 4 years ago

Indeed, I had not noticed, thank you for reporting this, I'll look into it.

lz100 commented 4 years ago

I made some other tests and found that waitress on button has the same issue but a little different.

  1. It is not responsive, if I change the window size while progress bar is running, it has the same issue as above.
  2. Progress bar is set to the highest z-index and it has a separate div that is on top of everything. That means the bar is not inside the parent element containing the button. If I have a collapsable div, when it is collapsed, you would still see the progress bar. example After collapse collapse