JohnCremona / eclib

The eclib package includes mwrank (for 2-descent on elliptic curves over Q) and modular symbol code used to create the elliptic curve database.
GNU General Public License v2.0
21 stars 15 forks source link

typo in xsplit.cc ? #21

Closed dimpase closed 7 years ago

dimpase commented 7 years ago

compiling with clang 4.0.1 I see

xsplit.cc:299:24: warning: use of unary operator that may be intended as compound assignment (-=)
    if(signeig<0) seig =- eig;

You might like to adjust spacing---assuming there it is meant to be ...= -eig

JohnCremona commented 7 years ago

Of course I mean seig = -eig. If you care, send a pull request.

dimpase commented 7 years ago

see https://github.com/JohnCremona/eclib/pull/22