search

JohnDoee / autotorrent

Matches torrents with files and gets them seeded
MIT License
269 stars 34 forks source link

Bug no output for okay torrents with deluged #27

Closed ghost closed 5 years ago

ghost commented 5 years ago

I found a bug I believe I thought it had to do with the new version and changes that occured in correcting the debugging but it seems to be with deluged and the if a label already exist

Deluge Found 1 torrent(s) Traceback (most recent call last): File "autotorrent-env/bin/autotorrent", line 11, in sys.exit(commandline_handler()) File "/home/snickerpop/autotorrent/autotorrent-env/local/lib/python2.7/site-packages/autotorrent/cmd.py", line 210, in commandline_handler result = at.handle_torrentfile(os.path.join(current_path, torrent), dry_run) File "/home/snickerpop/autotorrent/autotorrent-env/local/lib/python2.7/site-packages/autotorrent/at.py", line 468, in handle_torrentfile if self.client.add_torrent(torrent, destination_path, files['files'], fast_resume): File "/home/snickerpop/autotorrent/autotorrent-env/local/lib/python2.7/site-packages/autotorrent/clients/deluge.py", line 151, in add_torrent self.rpcclient.call('label.add', self.label) File "/home/snickerpop/autotorrent/autotorrent-env/local/lib/python2.7/site-packages/deluge_client/client.py", line 214, in call return self._receive_response(self.deluge_version) File "/home/snickerpop/autotorrent/autotorrent-env/local/lib/python2.7/site-packages/deluge_client/client.py", line 193, in _receive_response raise exception(exception_msg) deluge_client.client.WrappedException: Label already exists, Exception, Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/deluge-1.3.15-py2.7.egg/deluge/core/rpcserver.py", line 302, in dispatch ret = self.factory.methods[method](*args, **kwargs) File "build/bdist.linux-x86_64/egg/deluge/plugins/label/core.py", line 174, in add check_input(not (labelid in self.labels), ('Label already exists')) File "build/bdist.linux-x86_64/egg/deluge/plugins/label/core.py", line 68, in check_input raise Exception(message) Exception: Label already exists

The program is still works but if your doing something like 2>> or just want to see from the commandline the okay torrents. They are all missing and it only has found torrent message, and nothing about which torrent was found

For now the fix seems to be removing the label as it is not needed for deluge to run.

JohnDoee commented 5 years ago

It's a bit embarrassing, because I actually did this correctly in my streaming plugin.

Fixed, thanks for reporting it.

ghost commented 5 years ago

You closed the issue but I'm still seeing the same issue. I'm assuming you tested it out on the 1.3.15

Might just have to do with changes upcoming in deluge 2.0 Beta

JohnDoee commented 5 years ago

I indeed was, I'll try with Deluge 2

JohnDoee commented 5 years ago

How new is your Deluge 2? They changed the RPC Protocol and there's an open pull request for that here https://github.com/JohnDoee/deluge-client/pull/29

If it's linux and newer than mid November, that might be it.

ghost commented 5 years ago

Yeah it probably was around that time that I got it. I remember pulling the dev branch for install

JohnDoee commented 5 years ago

Try: pip install -U deluge-client and see if that changes anything.

If not, please post the full stacktrace.

ghost commented 5 years ago

Not sure what that command did but it fix the issue now.

JohnDoee commented 5 years ago

Updated the Deluge client autotorrent uses, seems like your Deluge was too new.

Happy it fixed it.