search

JohnDoee / deluge-client

A very lightweight pure-python Deluge RPC Client
MIT License
87 stars 14 forks source link

Convert tests to pytest #24

Closed gazpachoking closed 6 years ago

gazpachoking commented 6 years ago

Refs #23 For your consideration, here's how I would do the tests in pytest. It crept a little bit, and I added a base class for exceptions from the remote deluge host. I think this makes the test nicer, as well as making it better for scripts using the client to catch remote exceptions.

gazpachoking commented 6 years ago

Looks like python 3.3 is EOL and pytest (among other things) doesn't support it. Maybe we could drop that support from deluge-client. EDIT: Also removed 2.6 in this PR, it is also EOL, it wasn't being tested anyway, and pip doesn't work there due to SSL issues.

gazpachoking commented 6 years ago

My other 2 open PRs, (#21, #22,) will need some updating if we go this route, let me know what you are thinking.

JohnDoee commented 6 years ago

Just remove dead python releases. 2.6 was for ancient Debian version when I initially started.

gazpachoking commented 6 years ago

Okay, #21 and #22 are now on top of these changes. I think everything should go cleanly if this one goes first.